Ticket #198 (closed task: fixed)

Opened 3 years ago

Last modified 7 weeks ago

Rewrite Illume GSM module

Reported by: dolf1074 Owned by: ainulindale
Priority: major Milestone:
Component: SHR config Version: SHR-unstable
Keywords: gsm gadget Cc:

Description (last modified by spaetz) (diff)

Turning off the GSM modem, should result in a 'not active' GSM icon in the top panel.

If you turn the GSM modem off, you still get an icon with gsm reception on the illume top bar.

steps to repro:

  1. open settings and disable GSM
  2. look at the top bar

expected result:

  • it shows a non connected gsm icon

actual result:

  • it shows a connected phone with reception.

It also shouldn't display signal-bars when there is no signal coverage (text "No service" is displayed, but bars stays as they were)

Can /home/spaetz/src/shrbuildenv/shr-unstable/tmp/work/armv4t-angstrom-linux-gnueabi/e-wm-0.16.999.050+svnr41040-r5.3/temp/log.do_configure.3206

Change History

comment:1 Changed 3 years ago by dos

Looks like it's fixed in shr-unstable - after disabling GSM in settings in top panel is displayed "No Service" text.

comment:2 Changed 3 years ago by spaetz

  • Status changed from new to closed
  • Resolution set to fixed

comment:3 Changed 3 years ago by spaetz

  • Status changed from closed to reopened
  • Resolution fixed deleted

Reopening per discussion on IRC. The current "No Service" text could also appear in an area without coverage and is not necessarily a sign that we switched of GSM.

comment:4 Changed 3 years ago by spaetz

  • Keywords gsm gadget added
  • Version set to SHR-unstable
  • Milestone set to wishlist

Keeping this bug open. Basically we need to write a nice gsm gadget that is useful. THe current one is in the enlightenment svn and is difficult to adapt for SHR purposes, I guess

comment:5 Changed 3 years ago by TAsn

I think we should just contribute to the enlightenment one.
Or possibly make a new general one and commit it to enlightenment.

comment:6 Changed 3 years ago by dos

  • Component changed from SHR Image to SHR config
  • Type changed from defect to task
  • Description modified (diff)
  • Summary changed from Turning off the GSM modem, should result in a 'not active' GSM icon in the top panel to Rewrite Illume GSM module

Combining with #465. Shoudn't it be filled upstream? Or shouldn't we contribute upstream?

comment:7 Changed 3 years ago by TAsn

I actually thought about it, and I think we need to modify it to suite for our needs and only then commit upstream, atm we are too restricted by "leaving" stuff for upstream in this topic. We should think about it a bit more, that's why I think this ticket should remain open, at least for the meanwhile.

comment:8 Changed 3 years ago by dos

  • Milestone changed from wishlist to MS2

comment:9 follow-ups: ↓ 10 ↓ 11 Changed 3 years ago by Gorbusch

Implementation finished. Currently getting it into shr build and afterwards commited upstream.

comment:10 in reply to: ↑ 9 Changed 3 years ago by spaetz

  • Description modified (diff)

Replying to Gorbusch:

Implementation finished. Currently getting it into shr build and afterwards commited upstream.

That is great. I could not compile it so far. I would be happy if you worked with raster on getting it upstream.

comment:11 in reply to: ↑ 9 Changed 2 years ago by TAsn

  • Status changed from reopened to closed
  • Resolution set to fixed

Replying to Gorbusch:

Implementation finished. Currently getting it into shr build and afterwards commited upstream.

So I'm closing this one, I really noticed it got a lot better :)
Thanks.

comment:12 follow-up: ↓ 13 Changed 2 years ago by TAsn

  • Status changed from closed to reopened
  • Resolution fixed deleted

My bad, it seems that it's not there yet, so I was just imagining when I thought everything is better now. :)

comment:13 in reply to: ↑ 12 ; follow-up: ↓ 14 Changed 2 years ago by Gorbusch

Replying to TAsn:

My bad, it seems that it's not there yet, so I was just imagining when I thought everything is better now. :)

the fix should be still as an attachment in the mailing list, some time ago. I hope that i get back to shr dev with this or next weekend. Then i will try to get it upstream after a short recompile and retest.

comment:14 in reply to: ↑ 13 Changed 2 years ago by TAsn

Replying to Gorbusch:

Replying to TAsn:

My bad, it seems that it's not there yet, so I was just imagining when I thought everything is better now. :)

the fix should be still as an attachment in the mailing list, some time ago. I hope that i get back to shr dev with this or next weekend. Then i will try to get it upstream after a short recompile and retest.

Thanks a lot, I'm looking forward to see it happens :)

comment:15 Changed 2 years ago by TAsn

Closed dupe #801

comment:16 Changed 19 months ago by dos

  • Status changed from reopened to closed
  • Resolution set to fixed in unstable

comment:17 Changed 14 months ago by jama

  • Status changed from closed to reopened
  • Resolution fixed in unstable deleted

comment:18 Changed 14 months ago by jama

  • Status changed from reopened to closed
  • Resolution set to fixed

comment:19 Changed 7 weeks ago by morphis

  • Milestone MS2 deleted

Milestone MS2 deleted

Note: See TracTickets for help on using tickets.