Ticket #181 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

task-shr-minimal-x failes silently during bitbake shr-image, if locales-generation are disabled or crippled

Reported by: mywave Owned by: ainulindale
Priority: major Milestone:
Component: SHR git admin Version:
Keywords: Cc:

Description

Result is that make image generates an image that doesn't have X running per default

Attachments

task-shr-minimal-x.bb.patch Download (2.8 KB) - added by mywave 4 years ago.
task-shr-minimal-x.bb.patch

Change History

comment:1 Changed 4 years ago by ainulindale

  • Status changed from new to closed
  • Resolution set to fixed

Patch applied. Thanks ! :-)

comment:2 Changed 4 years ago by ainulindale

  • Status changed from closed to reopened
  • Resolution fixed deleted

Well, unfortunately, this doesn't behave as expected for a buildhost. In a buildhost case, all locales are generated but not included. IMAGE_LINGUAS is the right var to check for.

comment:3 in reply to: ↑ description Changed 4 years ago by mywave

Replying to mywave:

Result is that make image generates an image that doesn't have X running per default

So if IMAGE_LINGUAS set, it should override GLIBC_GENERATE_LOCALES? Or should we always check for IMAGE_LINGUAS, and let IMAGE_LINGAUS default to the value of GLIBC_GENERATE_LOCALES if unset in the shr baseclass?

Changed 4 years ago by mywave

task-shr-minimal-x.bb.patch

comment:4 Changed 4 years ago by mywave

Haven't tested the file in bitbake, but should behave as you demanded on IRC.. If GLIBC_GENERATE_LOCALES is empty or unset, fallback to IMAGE_LINGUAS before defaulting to "all"

comment:5 Changed 4 years ago by mywave

  • Status changed from reopened to closed
  • Resolution set to fixed

Patch is now 100% applied (with one spelling error fixed)

Note: See TracTickets for help on using tickets.